Skip to content

Migrate codelabs to material_ui - #2507

Merged
domesticmouse merged 20 commits into
flutter:mainfrom
domesticmouse:update-deps
Oct 7, 2026
Merged

domesticmouse merged 20 commits into
flutter:mainfrom
domesticmouse:update-deps

Conversation

@domesticmouse

@domesticmouse domesticmouse commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Migrating to material_ui.

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the standard 'package:flutter/material.dart' imports and dependencies with a third-party 'material_ui' package across multiple steps of the brick breaker codelab, while also updating SDK constraints and removing the '--include-xcode-workspace' flag from the Flutter clean steps. The reviewer feedback correctly advises against introducing the non-standard 'material_ui' package, recommending a revert to the official Flutter SDK's Material library to ensure security, compatibility, and adherence to standard Flutter development practices.

Comment thread brick_breaker/codelab_rebuild.yaml
Comment thread brick_breaker/codelab_rebuild.yaml
Comment thread brick_breaker/step_03/pubspec.yaml
Comment thread brick_breaker/step_03/lib/main.dart
@domesticmouse domesticmouse changed the title Update material_ui Migrate codelabs to material_ui Oct 2, 2026
@domesticmouse
domesticmouse requested a review from parlough October 3, 2026 05:13
@domesticmouse

Copy link
Copy Markdown
Contributor Author

PTAL @parlough =)

@parlough parlough left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@domesticmouse
domesticmouse merged commit 0c95835 into flutter:main Oct 7, 2026
13 checks passed
@bfritscher

Copy link
Copy Markdown

Hi, why mass upgrade all projects without doing proper testing? Your commit broke the official codelabs https://firebase.google.com/codelabs/firebase-get-to-know-flutter#1 because firebase_ui_auth still uses old material library. Using the codelabs for teaching in classroom :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants