Skip to content

Fix: responsive grids - #1038

Open
santipalenque wants to merge 4 commits into
masterfrom
fix/responsive-mui-table
Open

Fix: responsive grids#1038
santipalenque wants to merge 4 commits into
masterfrom
fix/responsive-mui-table

Conversation

@santipalenque

@santipalenque santipalenque commented Aug 7, 2026

Copy link
Copy Markdown

https://app.clickup.com/t/9014802374/86bb7tvh1

Summary by CodeRabbit

  • Bug Fixes

    • Archived sponsor forms now appear when “Show Archived” is enabled and remain hidden otherwise.
  • User Interface Improvements

    • Improved table responsiveness across media uploads, inventory, sponsor forms, templates, and purchase lists.
    • Updated sponsor form listings with flexible columns, wrapping, and responsive filter controls.
    • Invitation-only summits are now labeled beside their names.
    • Simplified summit deletion dialogs while retaining the warning message.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 18964371-97bf-45d3-9f36-073eb9cf6ce8

📥 Commits

Reviewing files that changed from the base of the PR and between cc662a8 and 2446f7d.

📒 Files selected for processing (2)
  • src/pages/sponsors/show-pages-list-page/__tests__/show-pages-list-page.test.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-pages-tab/__tests__/sponsor-pages-tab.test.js

📝 Walkthrough

Walkthrough

The change updates sponsor form archive filtering and revises table sizing across sponsor, inventory, media, purchase, form-template, and summit views. Summit invitation-only status now appears with the summit name.

Changes

Sponsor forms and table layout

Layer / File(s) Summary
Archive filter behavior
src/actions/sponsor-forms-actions.js, src/pages/sponsors/.../__tests__/*
Archived forms are excluded only when showArchived is false. Archive and unarchive tests select the action by test ID.
Sponsor forms list layout
src/pages/sponsors/sponsor-forms-list-page/index.js
Column widths, wrapping rules, filter controls, search controls, and action controls now use revised responsive sizing.
Table width normalization
src/pages/media_uploads/*, src/pages/sponsors-global/..., src/pages/sponsors/..., package.json
Fixed column widths and automatic table-layout settings are removed or reduced across related tables. The openstack-uicore-foundation dependency is updated.
Summit directory rendering and dialog cleanup
src/pages/summits/summit-directory-page.js
The invitation-only chip moves into the summit name column. The separate column and explicit table layout are removed. Delete-dialog configuration is reduced.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: smarcet

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main layout changes, including responsive grid sizing and removal of fixed table widths.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/responsive-mui-table

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/pages/sponsors/sponsor-forms-list-page/index.js (1)

211-218: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Add an overflow policy for long table values.

The code and name cells only set maxWidth. Line 281 forces the comma-separated tier label to stay on one line. Long codes or multiple tier names can widen or overflow the table on narrow screens.

Verify the MuiTable behavior and add wrapping or truncation. Allow tier labels to wrap and use overflowWrap: "anywhere" for constrained text.

Possible fix
-      cellSx: { maxWidth: 120 }
+      cellSx: {
+        maxWidth: 120,
+        overflowWrap: "anywhere"
+      }
...
-                whiteSpace: "nowrap",
+                whiteSpace: "normal",
+                overflowWrap: "anywhere",

Also applies to: 281-281

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/pages/sponsors/sponsor-forms-list-page/index.js` around lines 211 - 218,
Update the code and name column definitions in the table configuration, plus the
tier-label cell around the comma-separated value, to apply an explicit overflow
policy alongside maxWidth. Allow tier labels to wrap and set overflowWrap:
"anywhere" on constrained text, verifying the existing MuiTable styling behavior
so long codes and multiple tier names remain readable without widening or
overflowing the table.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/pages/sponsors/sponsor-forms-list-page/index.js`:
- Around line 211-218: Update the code and name column definitions in the table
configuration, plus the tier-label cell around the comma-separated value, to
apply an explicit overflow policy alongside maxWidth. Allow tier labels to wrap
and set overflowWrap: "anywhere" on constrained text, verifying the existing
MuiTable styling behavior so long codes and multiple tier names remain readable
without widening or overflowing the table.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 97a8419a-c2b4-4a3c-a03f-5e1eaa596e4e

📥 Commits

Reviewing files that changed from the base of the PR and between 39f4efc and 2cfff86.

📒 Files selected for processing (16)
  • src/actions/sponsor-forms-actions.js
  • src/pages/media_uploads/media-upload-list-page.js
  • src/pages/sponsors-global/form-templates/add-form-template-item-popup.js
  • src/pages/sponsors-global/form-templates/form-template-from-duplicate-popup.js
  • src/pages/sponsors-global/form-templates/form-template-item-list-page.js
  • src/pages/sponsors-global/inventory/inventory-list-page.js
  • src/pages/sponsors/show-purchase-list-page/index.js
  • src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-add-item-from-inventory-popup.js
  • src/pages/sponsors/sponsor-form-item-list-page/index.js
  • src/pages/sponsors/sponsor-forms-list-page/index.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/components/add-sponsor-form-template-popup/index.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/components/manage-items/sponsor-form-item-from-inventory.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/components/manage-items/sponsor-forms-manage-items.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/index.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-pages-tab/components/add-sponsor-page-template-popup/index.js
  • src/pages/summits/summit-directory-page.js
💤 Files with no reviewable changes (12)
  • src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/components/add-sponsor-form-template-popup/index.js
  • src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-add-item-from-inventory-popup.js
  • src/pages/sponsors-global/form-templates/add-form-template-item-popup.js
  • src/pages/sponsors-global/form-templates/form-template-item-list-page.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/components/manage-items/sponsor-forms-manage-items.js
  • src/pages/media_uploads/media-upload-list-page.js
  • src/pages/sponsors-global/form-templates/form-template-from-duplicate-popup.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/components/manage-items/sponsor-form-item-from-inventory.js
  • src/pages/sponsors/sponsor-form-item-list-page/index.js
  • src/pages/sponsors-global/inventory/inventory-list-page.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-pages-tab/components/add-sponsor-page-template-popup/index.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/index.js

@santipalenque
santipalenque force-pushed the fix/responsive-mui-table branch 3 times, most recently from b8c68ce to c7466dc Compare August 7, 2026 20:44
@fntechgit fntechgit deleted a comment from github-actions Bot Aug 7, 2026
@fntechgit fntechgit deleted a comment from github-actions Bot Aug 7, 2026
@fntechgit fntechgit deleted a comment from github-actions Bot Aug 7, 2026
@santipalenque
santipalenque force-pushed the fix/responsive-mui-table branch from c7466dc to df0d058 Compare August 7, 2026 21:03
@fntechgit fntechgit deleted a comment from github-actions Bot Aug 7, 2026
@santipalenque
santipalenque force-pushed the fix/responsive-mui-table branch from cc662a8 to c609c5f Compare August 7, 2026 21:16
@fntechgit fntechgit deleted a comment from github-actions Bot Aug 7, 2026
@santipalenque

Copy link
Copy Markdown
Author

/deploy-preview

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

🚀 Deployed on https://pr--show-admin-preview.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant