Skip to content

refactor: serve crawler jobs with Hono - #29

Merged
duncanleo merged 1 commit into
mainfrom
codex/use-hono-for-crawler
Oct 14, 2026
Merged

duncanleo merged 1 commit into
mainfrom
codex/use-hono-for-crawler

Conversation

@duncanleo

Copy link
Copy Markdown
Member

Replace the crawler’s manual Node HTTP request/response conversion with Hono and its official Node adapter. Keep startup and shutdown in the entry point, routes and signed-job handling in a small app module, and bounded streaming body reads in a dedicated helper.

Preserve QStash signature verification against the configured destination and untouched body, the 16 KiB limit, retry/overlap behavior, sanitized errors, and graceful shutdown. Acquisition, storage, schedules and deployment configuration are unchanged.

Validation: type checking, lint, 65 deterministic tests, Node build, production Docker build and container smoke checks. New regressions cover routing/HEAD behavior, expired signatures, byte boundaries, streamed overflow before EOF, configured-origin checks, real adapter requests and in-flight shutdown drain.

Use the official Node adapter and explicit Hono routes while preserving signed job execution and graceful shutdown. Bound streamed request bodies before signature verification and cover routing, auth, overflow and draining regressions.

Co-Authored-By: Codex <noreply@openai.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T07:23:54.199314Z 12973b4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
mrtdown-data-crawler 12973b4 Oct 14 2026, 07:21 AM

@duncanleo
duncanleo merged commit d1b2e1c into main Oct 14, 2026
2 of 3 checks passed
@duncanleo
duncanleo deleted the codex/use-hono-for-crawler branch October 14, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant