Repository navigation
refactor: serve crawler jobs with Hono - #29
Merged
Merged
Conversation
Use the official Node adapter and explicit Hono routes while preserving signed job execution and graceful shutdown. Bound streamed request bodies before signature verification and cover routing, auth, overflow and draining regressions. Co-Authored-By: Codex <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
mrtdown-data-crawler | 12973b4 | Oct 14 2026, 07:21 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the crawler’s manual Node HTTP request/response conversion with Hono and its official Node adapter. Keep startup and shutdown in the entry point, routes and signed-job handling in a small app module, and bounded streaming body reads in a dedicated helper.
Preserve QStash signature verification against the configured destination and untouched body, the 16 KiB limit, retry/overlap behavior, sanitized errors, and graceful shutdown. Acquisition, storage, schedules and deployment configuration are unchanged.
Validation: type checking, lint, 65 deterministic tests, Node build, production Docker build and container smoke checks. New regressions cover routing/HEAD behavior, expired signatures, byte boundaries, streamed overflow before EOF, configured-origin checks, real adapter requests and in-flight shutdown drain.