Skip to content

feat: open review PRs for new GTFS snapshots - #476

Merged
duncanleo merged 2 commits into
mainfrom
codex/gtfs-snapshot-review-pr
Nov 14, 2026
Merged

duncanleo merged 2 commits into
mainfrom
codex/gtfs-snapshot-review-pr

Conversation

@duncanleo

@duncanleo duncanleo commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Open a review PR for each new LTA train GTFS snapshot. Each PR links the source ZIP, validation outcomes, and available reports. Reviewers can see snapshots that failed validation, and repeated deliveries reuse the existing PR.

The workflow adds a capture record under docs/gtfs-captures/. Mapping changes and timetable release approval remain separate steps.

Verified with npm run check, all 881 deterministic tests, and a local simulation of review creation, duplicate delivery, and retry after a failed PR request.

Summary by CodeRabbit

  • New Features
    • Captures now open or reuse a review pull request on the default branch, with acquisition details, validation and inspection results, and available report links.
    • Review pull requests can still be created when validation reports errors.
  • Documentation
    • Updated handoff guidance to describe replay behavior, review pull requests, and the separate approval steps for mapping and timetable releases.

Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 43 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 47d8dd5b-7b7a-4d9d-aea9-e970bc2ac432
Commits

Reviewing files that changed from the base of the PR and between aff1d76 and 6812354.

Files selected for processing: 1

  • .github/workflows/gtfs-capture.yml

No actionable comments were generated in the recent review.

Walkthrough

The capture workflow now exposes acquisition and inspection results to a default-branch job. That job checks for an existing review PR for the snapshot hash and creates one if needed. The handoff documentation describes the updated workflow and its permissions.

Changes: GTFS capture review

Layer / File(s) Summary
Capture and inspection outputs
.github/workflows/gtfs-capture.yml
The inspect job exposes the snapshot hash, retrieval time, validation and inspection outcomes, and artifact URL. Acquisition writes the hash and retrieval time to job outputs.
Review PR creation and handoff
.github/workflows/gtfs-capture.yml, docs/gtfs-public-handoff.md
A default-branch job checks for a PR matching the snapshot hash and creates one if none exists. The capture record includes validation details and an optional artifact link. The documentation describes replay behavior, PR contents, and permissions.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant inspect as inspect job
  participant review as review job
  participant repository as GitHub repository
  inspect->>review: Provide capture and inspection outputs
  review->>repository: Check for a PR matching the snapshot hash
  alt No matching PR exists
    review->>repository: Push hash-named branch with capture record
    review->>repository: Open PR for the branch
  end
Loading
Merge Risk: Minimal · previous review aff1d

This change opens or reuses one review PR per new GTFS snapshot hash, including snapshots that fail validation. The inspected workflow and docs line up, and no concrete defect was found. Before relying on it, confirm that the repository allows GitHub Actions to create pull requests. If it does not, the job will push capture branches but fail to open PRs.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "feat: open review PRs for new GTFS snapshots" matches the main change. The workflow gains a review job that opens a review PR for each new GTFS snapshot hash, and the docs describe the same…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "feat: open review PRs for new GTFS snapshots" matches the main change. The workflow gains a review job that opens a review PR for each new GTFS snapshot hash, and the docs describe the same behavior. The objectives confirm the title's intent: one review PR per snapshot, with reuse on repeated delivery.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8f12a8c7-edbd-4a76-907b-46476b7330f4
Commits

Reviewing files that changed from the base of the PR and between 902f543 and aff1d76.

Files selected for processing: 2

  • .github/workflows/gtfs-capture.yml
  • docs/gtfs-public-handoff.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T19:13:00.907944Z 6812354 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-Authored-By: Codex <noreply@openai.com>
@duncanleo
duncanleo merged commit e06a9f3 into main Nov 14, 2026
2 checks passed
@duncanleo
duncanleo deleted the codex/gtfs-snapshot-review-pr branch November 14, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant