Release: Merge dev into master (Docker Multistage, Core Cleanup, and GUI Updates) - #150
Merged
Conversation
Updated video link for Docker quick start instructions.
* init entrypoint script #125 * docker CP is more optimized
* init entrypoint script #125 * docker CP is more optimized * move forefire executable code to /app * final docker * comment
Replace local video link with GitHub asset link
Line 44 was launching tests in runff directory instead of runANN (line 44)
The if/else above (line 54-63) always exits, so ./clean.bash is never reached.
[docker] Multi-stage Dockerfile
fix: double-free in FireFront cleanup
[tests] fix run.bash bugs
New EMIT function/interface added and deprecated volcano/lava flux models removed since v2.2.1 warrant a minor version bump.
Step numbering had gaps (2 -> 5 -> 6) and a malformed list marker/code fence around the listenHTTP[] step; also cleaned up two typos in the 'Run your first simulation' step.
Collaborator
Author
|
I discussed the merge DEV-> MASTER with @filippi that approved the merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings
masterup to date with the latest developments from thedevbranch, consolidating several bug fixes, architectural improvements to our Docker setup, and a major GUI update.Key Changes:
Dockerfileas a multi-stage build, significantly improving build times and reducing the final image size. Cleaned up obsolete devops scripts (tools/devops). Bumped GitHub Actions (actions/checkout@v4→v6) and renamed workflow jobs for clarity.FireFrontcleanup.EMITfunction and interface (Command.cpp).forefireGUI.jsand styling, introducing a new and improved web interface.run.bash), addedFUELCOVER.md, and updated documentation links.Checklist: