Skip to content

ci: remove dangling esp8266 include block - #435

Merged
forntoh merged 1 commit into
masterfrom
fix/esp8266-compile-include
Sep 28, 2026
Merged

forntoh merged 1 commit into
masterfrom
fix/esp8266-compile-include

Conversation

@forntoh

@forntoh forntoh commented Sep 28, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Removes the dangling esp8266 include block from the Compile Examples workflow matrix.

Why

Since bbd2b8f ("Remove esp8266 board configuration from compile workflow") removed the esp8266 matrix board entry, the leftover include block (no fqbn, empty libraries/sketch-paths) has spawned a broken esp8266 job on every workflow run — it fails with IndexError: list index out of range before compiling anything (see the failed job on #433 and #434). That commit's own verification run was cancelled, so the breakage went unnoticed.

This completes the original removal intent and un-breaks the compile workflow for all current and future PRs.

Verification

  • git diff: only the 9-line esp8266 include block removed; the four board matrix entries (esp32, avr:uno, mkr1000, stm32) and all remaining include blocks (AVR, ESP32, SAMD, STM32) are untouched.
  • YAML validated: yaml.safe_load (temp venv) and independently via ruby YAML.load_file — both pass.

Notes

  • If the esp8266 compile job is listed as a required status check in branch protection, that repository setting should be updated after this merges.
  • After this merges, open PRs with a recorded failed esp8266 job (e.g. fix: make GraphicalDisplayRenderer subclassable #433) may need a branch update to re-run checks.

Summary by CodeRabbit

  • Chores
    • Automated build validation no longer includes ESP8266 board configurations. This changes which board builds are checked automatically; it does not describe a change to the behavior of existing devices.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 62eea60d-55db-4eb1-aac7-1e5458000a80

📥 Commits

Reviewing files that changed from the base of the PR and between 56bfce7 and b99e5c1.

📒 Files selected for processing (1)
  • .github/workflows/compile-arduino.yml
 ___________________________________________________________________
< Your feature is behind a flag. Your bug is already in production. >
 -------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@forntoh forntoh added the chore Chore task label Sep 28, 2026
@forntoh
forntoh merged commit e3c1c93 into master Sep 28, 2026
10 of 11 checks passed
@forntoh
forntoh deleted the fix/esp8266-compile-include branch September 28, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chore task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant