ci: remove dangling esp8266 include block - #435
Merged
Merged
Conversation
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includeblock from the Compile Examples workflow matrix.Why
Since bbd2b8f ("Remove esp8266 board configuration from compile workflow") removed the esp8266 matrix board entry, the leftover
includeblock (nofqbn, emptylibraries/sketch-paths) has spawned a broken esp8266 job on every workflow run — it fails withIndexError: list index out of rangebefore compiling anything (see the failed job on #433 and #434). That commit's own verification run was cancelled, so the breakage went unnoticed.This completes the original removal intent and un-breaks the compile workflow for all current and future PRs.
Verification
git diff: only the 9-line esp8266 include block removed; the four board matrix entries (esp32, avr:uno, mkr1000, stm32) and all remaining include blocks (AVR, ESP32, SAMD, STM32) are untouched.yaml.safe_load(temp venv) and independently via rubyYAML.load_file— both pass.Notes
Summary by CodeRabbit