Repository navigation
Use the FORRT --color-* tokens directly and set 14px body text - #22
Merged
Merged
Conversation
WIP: token layer consolidation; see PR description. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Plain links use --color-link instead of Bootstrap's #0d6efd (3.6:1 on the dark page); inline code uses the brand colour instead of Bootstrap's pink (3.4:1 dark). - Footer tagline opacity 0.5 -> 0.62 (4.14:1 -> above 4.5:1). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Resolve conflicts with #19 and #20: renderMcCharts keeps FloraCharts.theme() (which also drops the stale #8b1a4a fallback), and the outlined-button rules keep this branch's --color-* tokens with #20's per-button transition timings. Also restore a visible stats-card hover border (--color-primary-border); it had become a no-op after the token rename (cubic review). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #20. Merge #20 first; GitHub will then retarget this PR to
main.The explorer kept its own
--flora-*colour layer next to the FORRT tokens: 318 uses instyles.cssagainst 7 for--color-*. Only some--flora-*names were aliased, so dark mode mixed the plum FORRT surfaces with leftover blue-grey ones (inputs, callouts, subtle panels, borders, muted text). This brings back the single-token-layer part of the closed #7 and applies your decision on body size.Changes
--flora-*uses in CSS, HTML and JS map onto--color-*, and the three--flora-*definition blocks are deleted. Notable mappings:--color-muted-fg, not--color-text-muted, because#888fails 4.5:1;--color-border;--color-surface-subtle/--color-surface-alt;--color-neutral.ds-tokens.css:--color-link(#2563eblight, 5.17:1 on white, replacing#4299e1at 2.97:1;#93b4fddark),--color-shadow,--color-shadow-hoverand--color-callout-accent.--flora-primary-dark-accentare deleted.--color-primaryalready lightens in dark mode, so one rule now serves both themes; dark-only rules go from 35 to 12, all of them Bootstrap/DataTables overrides.--color-on-primaryinstead of#fff. White on the dark-mode pink was 2.56:1. Solid outcome badges keep their theme-independent colours.--shadow-focus-primary,--color-scrimand--shadow-lg.codeuse--color-linkand--color-primaryinstead of Bootstrap's defaults. The footer tagline opacity goes from 0.5 to 0.62.--text-md), including Bootstrap's--bs-body-font-size, so tables and controls follow. Running copy (intro, FAQ answers, chart descriptions, callouts, citation box) uses the same size..notedrops to 13px (--text-base) to stay a step below body. Headings, titles and KPI numbers are unchanged.Verification
Contrast audit: every visible text element on all seven tabs, in both themes, with the composited background.
Remaining:
.study-type-notemuted text on the page background is 4.39:1, from the FORRT--color-muted-fgtoken.Screenshots: four tabs in both themes. No page errors; computed body size is 14px.
Python tests pass locally; the browser suite is left to CI.
🤖 Generated with Claude Code
Summary by cubic
Replaces the explorer's
--flora-*colour tokens with the FORRT--color-*tokens directly, so dark mode no longer mixes plum surfaces with leftover blue-grey ones, and sets body text to 14px. Stacked on #20 — merge that first; GitHub will then retarget this PR tomain.One token layer
--flora-*uses in CSS, HTML, and JS now map to--color-*, and the--flora-*definition blocks are deleted. Chart rendering is consolidated on the same layer: Mean Citedness charts go throughFloraCharts.theme(), which drops the stale#8b1a4afallback.--color-muted-fg(#888fails 4.5:1); panels, borders, and the top bar and footer use--color-surface-*,--color-border, and--color-neutral.ds-tokens.css:--color-link,--color-shadow,--color-shadow-hover, and--color-callout-accent.--color-primaryalready lightens in dark mode, so dark-only rules drop from 35 to 12.--color-on-primaryinstead of#fff, which was 2.56:1 on the dark-mode pink. Outcome badges keep their theme-independent colours.codeuse--color-linkand--color-primaryinstead of Bootstrap's defaults; focus rings, the modal backdrop, and modal shadow use--shadow-focus-primary,--color-scrim, and--shadow-lg. Footer tagline opacity goes from 0.5 to 0.62, and the stats-card hover border returns via--color-primary-border(it had become a no-op after the rename).Typography and contrast
--text-md), including Bootstrap's--bs-body-font-size; running copy and the citation box use the same size, while.notedrops to 13px. Headings and KPI numbers are unchanged..study-type-noteat 4.39:1.Written for commit afbc2c4. Summary will update on new commits.