Repository navigation
fix: render a dynamic prop whose default is a number, boolean or object - #1082
Open
jaydev-CAstra wants to merge 1 commit into
Open
jaydev-CAstra wants to merge 1 commit into
jaydev-CAstra wants to merge 1 commit into
Conversation
The fallback of a bound standard prop went through escape_single_quotes, which calls .replace on the parsed default, so a number, true boolean or object default raised AttributeError and the page failed to render. Write the default as a Jinja literal of its own type instead.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a component prop with a number, boolean or object default is bound to page data, the published page fails with AttributeError.
get_dynamic_props_template passes the parsed default to escape_single_quotes, which calls replace on it, so only string defaults work. A false boolean default also came out as an empty string.
This writes the fallback with to_jinja_literal, the same helper used for defaults of props that are not bound, so 25 stays a number and true stays a boolean. String defaults render as before.
Added a test where a bound number prop with default 25 renders 25 when its data is missing.