Skip to content

feat(ai): open the editor on Bob on Frappe Cloud v2 - #1085

Merged
surajshetty3416 merged 5 commits into
frappe:developfrom
surajshetty3416:feat/bob-default-on-cloud-v2
Nov 14, 2026
Merged

surajshetty3416 merged 5 commits into
frappe:developfrom
surajshetty3416:feat/bob-default-on-cloud-v2

Conversation

@surajshetty3416

Copy link
Copy Markdown
Member

Summary

On Frappe Cloud v2 the editor now opens on Bob instead of Layers. Running the full onboarding on a v2 test site turned up three rough edges in the Bob panel, fixed in their own commits.

Bob first on Cloud v2. Cloud v2 sites come with Bob connected, so the left panel starts on Bob there.

 leftPanelActiveTab:
-  "Layers"
+  Cloud Settings enabled ? "Chat" : "Layers"

A site counts as v2 when Cloud Settings is enabled: pilot_endpoint and pilot_auth_token in site config, and the user is a System Manager. Cloud v1, self-hosted sites and the editor demo keep Layers. "Use all pages" on a template group still opens Layers, so the imported folder's pages show.

Header with no chat title. The header kept an empty second line for the chat title, so with no chat yet "Bob AI" sat above a blank strip. It now has a fixed height and centers what it holds, so a title arriving later still doesn't move the chat.

Escape on the "/" menu. Only the composer listened for Escape, so the menu stayed open once focus left it. An Escape shortcut, live while the menu is open on the Bob tab, now steps back a level or closes it.

ChatGPT sign-in progress. After the code was copied, nothing changed until the success toast. The poll that saw the approval also swapped the code for tokens and listed the models, so the menu had no moment to show that step.

 poll(state)
   not approved yet -> pending
-  approved -> exchange code, add provider -> connected
+  approved -> keep the approval -> approved
+  next poll -> exchange code, add provider -> connected

The menu now says "Code copied. Waiting for you to approve it on ChatGPT…", then "Approved. Connecting to ChatGPT…".

Evidence

A v2 site, right after "Start blank":

Editor opening on Bob

Before After
Header before Header after
Waiting for approval Connecting
Waiting for approval Connecting

Merge Danger

Door: two-way

Blast Radius: small

New System Managers on v2 sites land on Bob instead of Layers. An editor tab opened before the deploy reads approved as still pending and connects on its next poll.

surajshetty3416 and others added 4 commits November 14, 2026 12:46
Cloud v2 sites come with Bob connected, so the editor's left panel starts on
Bob AI there instead of Layers. A site counts as v2 when Cloud Settings is
enabled, which also needs the user to be a System Manager.

Co-Authored-By: Claude <noreply@anthropic.com>
The header kept an empty second line for the chat title, so with no chat yet
(no model connected, or a page without chats) the title sat on top of a blank
strip. A fixed height now centers whatever the header holds, which still keeps
the chat from moving when a title arrives.

Co-Authored-By: Claude <noreply@anthropic.com>
…focus

Only the composer listened for Escape, so once focus moved elsewhere the "/"
menu stayed open. An Escape shortcut, live while the menu is open on the Bob
tab, now steps back a level or closes it, like Escape in the composer.

Co-Authored-By: Claude <noreply@anthropic.com>
After the code was copied the menu showed no sign of life until the toast.
It now says it is waiting for approval, then that it is connecting. The poll
reports the approval as soon as OpenAI does and leaves the token exchange and
model lookup to the next poll, so the connecting step is visible.

Co-Authored-By: Claude <noreply@anthropic.com>
@mergify

mergify Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

This pull request is merged.

@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.42%. Comparing base (86b6975) to head (5eca182).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1085   +/-   ##
========================================
  Coverage    81.42%   81.42%           
========================================
  Files           70       70           
  Lines         7541     7541           
========================================
  Hits          6140     6140           
  Misses        1401     1401           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-Authored-By: Claude <noreply@anthropic.com>
@surajshetty3416
surajshetty3416 merged commit a62a96e into frappe:develop Nov 14, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant