Skip to content

Add interactive GitHub Pages demo - #107

Merged
fraserxu merged 1 commit into
masterfrom
codex/demo-page
Jul 11, 2026
Merged

fraserxu merged 1 commit into
masterfrom
codex/demo-page

Conversation

@fraserxu

@fraserxu fraserxu commented Jul 11, 2026 •

Copy link
Copy Markdown
Owner

What changed

  • add a dependency-light interactive demo under docs/
  • load the published react-chartist 1.0 package with React 19 and Chartist 1.5
  • demonstrate Line, Bar, and Pie chart recreation plus in-place data updates
  • add responsive, accessible styling and link the live demo from the README

Why

The existing gh-pages site is a broken legacy bundle from the pre-1.0 project. Keeping the demo as static files under master/docs makes the Pages deployment easy to inspect and avoids another build toolchain.

Validation

  • npm run check
  • Line, Bar, and Pie interactions verified in a browser
  • data update verified by SVG path change
  • mobile layout verified at 390px with no horizontal overflow

Note

Low Risk
Documentation and static demo assets only; no library runtime or API changes.

Overview
Replaces the broken legacy gh-pages experience with a static, build-free demo in docs/ for GitHub Pages, and links it from the README.

The demo loads react-chartist 1.0, React 19, and Chartist 1.5 via an import map (esm.sh), with docs/.nojekyll so Jekyll does not interfere. docs/demo.js drives an interactive workbench: switch Line / Bar / Pie, update data in place, and surface Chartist created events in a live readout. docs/style.css adds landing-page layout, chart theming, focus styles, and responsive breakpoints.

No changes to the published library package—only docs and the README demo link.

Reviewed by Cursor Bugbot for commit 0578072. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0578072. Configure here.

Comment thread docs/demo.js
h("span", { className: "plotter-coordinate plotter-coordinate-x" }, "x / 07"),
h("span", { className: "plotter-coordinate plotter-coordinate-y" }, "y / 26"),
h(ChartistGraph, {
"aria-label": `${type} chart showing a seven-day sample`,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pie chart wrong aria label

Medium Severity

The ChartistGraph aria-label always says the chart shows a seven-day sample. In Pie mode the data is three product categories, not weekdays, so assistive technologies announce a misleading description when users switch to Pie.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0578072. Configure here.

@fraserxu
fraserxu merged commit aca4b2c into master Jul 11, 2026
5 checks passed
@fraserxu
fraserxu deleted the codex/demo-page branch July 11, 2026 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant