Repository navigation
Add interactive GitHub Pages demo - #107
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0578072. Configure here.
| h("span", { className: "plotter-coordinate plotter-coordinate-x" }, "x / 07"), | ||
| h("span", { className: "plotter-coordinate plotter-coordinate-y" }, "y / 26"), | ||
| h(ChartistGraph, { | ||
| "aria-label": `${type} chart showing a seven-day sample`, |
There was a problem hiding this comment.
Pie chart wrong aria label
Medium Severity
The ChartistGraph aria-label always says the chart shows a seven-day sample. In Pie mode the data is three product categories, not weekdays, so assistive technologies announce a misleading description when users switch to Pie.
Reviewed by Cursor Bugbot for commit 0578072. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What changed
docs/Why
The existing
gh-pagessite is a broken legacy bundle from the pre-1.0 project. Keeping the demo as static files undermaster/docsmakes the Pages deployment easy to inspect and avoids another build toolchain.Validation
npm run checkNote
Low Risk
Documentation and static demo assets only; no library runtime or API changes.
Overview
Replaces the broken legacy gh-pages experience with a static, build-free demo in
docs/for GitHub Pages, and links it from the README.The demo loads react-chartist 1.0, React 19, and Chartist 1.5 via an import map (
esm.sh), withdocs/.nojekyllso Jekyll does not interfere.docs/demo.jsdrives an interactive workbench: switch Line / Bar / Pie, update data in place, and surface Chartistcreatedevents in a live readout.docs/style.cssadds landing-page layout, chart theming, focus styles, and responsive breakpoints.No changes to the published library package—only docs and the README demo link.
Reviewed by Cursor Bugbot for commit 0578072. Bugbot is set up for automated code reviews on this repo. Configure here.