Skip to content

Song and category edit fixes + tests - #569

Merged
hannesblaman merged 2 commits into
mainfrom
song-edit-fix
Aug 28, 2026
Merged

Song and category edit fixes + tests#569
hannesblaman merged 2 commits into
mainfrom
song-edit-fix

Conversation

@hannesblaman

@hannesblaman hannesblaman commented Aug 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Fixed song edit bug where it was not allowed to submit any edits on the song since it always found a song with the same name (itself).
  • Fixed being able to edit song categories to be the same name
  • Added case-insensitive song title comparisons
  • Added tests

@hannesblaman
hannesblaman marked this pull request as ready for review August 22, 2026 22:37
georgelgeback
georgelgeback approved these changes Aug 28, 2026
View reviewed changes

@georgelgeback georgelgeback left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can't believe this was a bug we had

@hannesblaman
hannesblaman merged commit bf59605 into main Aug 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georgelgeback georgelgeback georgelgeback approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hannesblaman @georgelgeback