async support with feature - #30
Conversation
|
@Finomnis what do you think? |
|
Features should enable capabilities but they should not remove them (like what you do with the original sync function) Reason is that other libraries might enable features out of your control. But that's a general guideline, if you say this crate is enduser specific, then maybe this might be a solution, yes. |
|
I agree that additiveness of features is a valid concern here. Even if one were to assume that CLI types wouldn't leak into library APIs, it's conceivable that an application would want to use both blocking and futures-based APIs in different areas. I'd prefer to make an |
|
Now async is separate api, by deafult the sync api is always there to be backwards compatible. @funbiscuit what do you think? |
add async processor support using
maybe_async_cfg2on feature "async".I tried running memory.sh and I'm getting weird results, there are 200 more bytes in every measure in every test, but when comparing actual binary size with
cargo sizeoravr-size, the main branch and this branch are equal.I used this command(
avr-objcopy -O ihex binary.elf binary.hex) to get the raw binary, and the two files(old and new) do not differ.