Skip to content

Relabel node/edge_ids when node_id start at 0 (crashes motile_tracker) - #272

Open
TeunHuijben wants to merge 6 commits into
mainfrom
node-id-start-0
Open

Relabel node/edge_ids when node_id start at 0 (crashes motile_tracker)#272
TeunHuijben wants to merge 6 commits into
mainfrom
node-id-start-0

Conversation

@TeunHuijben

@TeunHuijben TeunHuijben commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Closes #248

motile_tracker has the problem that the segmentation looks weird when the graph/geff has node_ids starting at 0

This PR add a funtracks function that, upon graph building, relabels the node_ids (and accompanying edge_ids) to start at 1 (all +1)

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.83%. Comparing base (afb6c4d) to head (5901596).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/funtracks/import_export/_tracks_builder.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   93.92%   93.83%   -0.09%     
==========================================
  Files          59       59              
  Lines        3323     3342      +19     
==========================================
+ Hits         3121     3136      +15     
- Misses        202      206       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TeunHuijben
TeunHuijben marked this pull request as ready for review August 12, 2026 16:43
@TeunHuijben TeunHuijben added 🐛 bug Something isn't working ready for initial review PR ready for first review labels Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working ready for initial review PR ready for first review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segmentation ugly when node_ids start at 0

3 participants