Repository navigation
Conversation
AUTODOC_CurrentDirectory ran the pwd program, which under MSYS2 prints a path such as /c/gap2 that native Windows programs cannot use. Several places also took a path to be absolute only if it starts with a slash, so on Windows they prefixed an absolute C:/... path with that directory, yielding /c/gap2/C:/gap2/... . Use GAP_getcwd, and recognize drive paths as absolute via the new AUTODOC_IsAbsolutePath. Assisted-by: Claude Code (Opus 5)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 93.03% 93.06% +0.02%
==========================================
Files 15 15
Lines 3131 3130 -1
==========================================
Hits 2913 2913
+ Misses 218 217 -1
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AUTODOC_CurrentDirectory ran the pwd program, which under MSYS2 prints a path such as /c/gap2 that native Windows programs cannot use. Several places also took a path to be absolute only if it starts with a slash, so on Windows they prefixed an absolute C:/... path with that directory, yielding /c/gap2/C:/gap2/... . Use GAP_getcwd, and recognize drive paths as absolute via the new AUTODOC_IsAbsolutePath.
Assisted-by: Claude Code (Opus 5)
GAP_getcwdis only available in recent GAP; andAUTODOC_IsAbsolutePathis probably something we should have built into GAP. So I am not sure we'll want to keep this as it is. Hrm.