Skip to content

Make the Makefile self-documenting - #380

Merged
fingolfin merged 1 commit into
masterfrom
mh-claude/Makefile
Sep 28, 2026
Merged

fingolfin merged 1 commit into
masterfrom
mh-claude/Makefile

Conversation

@fingolfin

Copy link
Copy Markdown
Member

Running make or make help now lists the targets, taken from their ## description comments, and explains how to pick a GAP executable.

Also:

  • resolve paths relative to the Makefile, so make -f works from any directory
  • quote the package directory, so paths with spaces work
  • spell out the patterns in clean, which relied on bash brace expansion and deleted nothing under a POSIX /bin/sh such as dash
  • add test as an alias for check

Assisted-by: Claude Code (Opus 5.5)

Running `make` or `make help` now lists the targets, taken from their
`## description` comments, and explains how to pick a GAP executable.

Also:
- resolve paths relative to the Makefile, so `make -f` works from
  any directory
- quote the package directory, so paths with spaces work
- spell out the patterns in `clean`, which relied on bash brace
  expansion and deleted nothing under a POSIX /bin/sh such as dash
- add `test` as an alias for `check`

Assisted-by: Claude Code (Opus 5.5)
@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.03%. Comparing base (e2d1900) to head (be27f45).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #380   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files          15       15           
  Lines        3131     3131           
=======================================
  Hits         2913     2913           
  Misses        218      218           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin
fingolfin marked this pull request as ready for review September 28, 2026 13:35
@fingolfin
fingolfin merged commit 98692f4 into master Sep 28, 2026
5 checks passed
@fingolfin
fingolfin deleted the mh-claude/Makefile branch September 28, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant