Skip to content

Use the package more, decide what needs to be done for a first release #71

Open

Description

@fingolfin

When we talked about this package yesterday it was stated that some work remains to be done, but it wasn't quite clear what. We already applied some basic polish, and are working on resolving TODOs in the documentation, but what else has to be done?

One good gauge is to try and use the package. Some notes on that end

Activity

  1. james-d-mitchell commented on Sep 29, 2026

    @james-d-mitchell
    Collaborator

    If I can add some more stuff here (this is probably non-essential, but desirable):

    • remove GV_ValidColorNames
    • remove GV_KNOWN_ATTRS. This is probably more necessary than I originally thought, there are several lines in the code like if not name in GV_KNOWN_ATTRS when the type of name is IsObject, so this will give all manner of false warnings when name isn't a string.
    • remove GV_IsMap and the related stuff, basically these are just records, and so there's no point in the category existing.
  2. james-d-mitchell commented on Sep 29, 2026

    @james-d-mitchell
    Collaborator

    Also re: digraphs/Digraphs#644 I'm happy to revise this PR, and will be free after noon today to do it, unless someone beats me to it.

  3. ruthhoffmann commented on Sep 29, 2026

    @ruthhoffmann
    Member

    Through usage here are the issues that would be useful to have resolved before advertising this pkg as a solution to other GAP pkg devs:

    I realise I am repeating what James already said (this was drafted before his message) and I will make this list grow as I find "features".

  4. dvberkel commented on Sep 29, 2026

    @dvberkel
    Collaborator

    I ticked the boxes of the issues (#66, #78) that were closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions