Repository navigation
Remove getters and setters using square brackets - #116
Merged
james-d-mitchell merged 5 commits intoOct 2, 2026
Merged
Conversation
MeikeWeiss
requested changes
Oct 1, 2026
MeikeWeiss
left a comment
MeikeWeiss
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! I have just one small thing which I think should be changed.
Collaborator
Author
Sure, what is it? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 95.39% 95.31% -0.09%
==========================================
Files 12 12
Lines 1346 1322 -24
==========================================
- Hits 1284 1260 -24
Misses 62 62 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MeikeWeiss
reviewed
Oct 1, 2026
reiniscirpons
approved these changes
Oct 1, 2026
reiniscirpons
left a comment
reiniscirpons
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @james-d-mitchell , looks good to me!
james-d-mitchell
force-pushed
the
rm-sqr-bracket-ops
branch
from
October 2, 2026 09:20
6f1e4c4 to
1f3ced1
Compare
james-d-mitchell
enabled auto-merge (rebase)
October 2, 2026 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially resolves #114. It seems like removing the (node) getter
\[\]fromIsGraphvizGraphDigraphOrContextwill be easier after resolving:#77 (comment)