Skip to content

gv: attrs are always a record - #122

Merged
james-d-mitchell merged 2 commits into
gap-packages:mainfrom
james-d-mitchell:attrs-always-record
Oct 4, 2026
Merged

james-d-mitchell merged 2 commits into
gap-packages:mainfrom
james-d-mitchell:attrs-always-record

Conversation

@james-d-mitchell

Copy link
Copy Markdown
Collaborator

This PR simplifies and unifies the setting of attributes for graphs, nodes, and edges. As discusses in #77, it should also resolve #75

@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.34884% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.90%. Comparing base (dc9a11f) to head (88a66d4).

Files with missing lines Patch % Lines
gap/dot.gi 92.30% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   95.27%   94.90%   -0.37%     
==========================================
  Files          12       12              
  Lines        1312     1257      -55     
==========================================
- Hits         1250     1193      -57     
- Misses         62       64       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@james-d-mitchell
james-d-mitchell merged commit f851d16 into gap-packages:main Oct 4, 2026
8 checks passed
@james-d-mitchell
james-d-mitchell deleted the attrs-always-record branch October 4, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent GraphvizSetAttr

1 participant