Repository navigation
PackageInfo.g: add SOTGrps to SuggestedOtherPackages - #75
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 510 510
Lines 373389 373389
=======================================
Hits 372971 372971
Misses 418 418 🚀 New features to boost your workflow:
|
Member
Author
|
@beick @heikodietrich for your information |
fingolfin
commented
Sep 17, 2026
fingolfin
force-pushed
the
mh/suggest-sglppow-sotgrps
branch
from
September 17, 2026 15:10
853353d to
6972cc8
Compare
|
Thanks - that's a great addition! |
fingolfin
force-pushed
the
mh/suggest-sglppow-sotgrps
branch
from
October 1, 2026 20:11
b53463d to
51f0194
Compare
fingolfin
changed the title
Member
Author
|
So, change of plans: for now this will only do SOTGrps. The reason is that there are technical difficulties with SglPPow; while those can be overcome, the other issue there is more grave: that package also brings in LieRing, LiePRing, and singular; so effectively instead of adding another two default loaded packages, we'd be adding 5. I don't feel comfortable doing that. It is not even clear to me why the But I'll have a look and perhaps I can defuse some of these dependencies via the package extension mechanism. If so, I'll revisit this problem. |
This way it is loaded by default for most users. SglPPow is not suggested: it would pull its own suggestions LieRing, LiePRing and, through LiePRing, Singular into every GAP startup. With SOTGrps loaded, two test files no longer described the situation they assumed, so both now hide the layers other packages register and put them back afterwards: - addlayer.tst spells out the layer list around its stand-in layers, and SOTGrps took a slot in it. Its restore step rebuilt SMALL_GROUPS_LAYERS from scratch, which dropped foreign layers for every later test file; it now puts back the record it saved. - small.tst lists the orders this library has no groups or no identification for, and SOTGrps covers some of them, 2662 = 2*11^3 among them. Assisted-by: Claude Code (Opus 5) Assisted-by: Claude Code (Opus 5.5)
fingolfin
force-pushed
the
mh/suggest-sglppow-sotgrps
branch
from
October 1, 2026 20:52
51f0194 to
88ad2fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way it is loaded by default for most users.
SglPPow is not suggested, since it would pull LieRing, LiePRing and Singular into every GAP startup.
🤖 Generated with Claude Code