Repository navigation
Reduce reliance on the IMMUTABLE tnum bit in the plain list code - #6707
Merged
Merged
Conversation
fingolfin
added
topic: kernel
release notes: not needed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6707 +/- ##
==========================================
- Coverage 79.56% 79.55% -0.02%
==========================================
Files 684 684
Lines 295665 295512 -153
Branches 8656 8656
==========================================
- Hits 235259 235100 -159
- Misses 58582 58590 +8
+ Partials 1824 1822 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fingolfin
force-pushed
the
mh-claude/immutable-prep-refactorings
branch
from
October 8, 2026 20:15
4db271a to
16a3fc4
Compare
james-d-mitchell
left a comment
james-d-mitchell
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, mod the minor comments about re-adding some assertions.
| else if (TEST_OBJ_FLAG(elm, OBJ_FLAG_TESTING)) { | ||
| isHom = FALSE; | ||
| areMut = IS_PLIST_MUTABLE(elm); | ||
| areMut = IS_MUTABLE_OBJ(elm); |
Contributor
There was a problem hiding this comment.
Same comment as before, maybe add an assertion at the start of this function?
Member
Author
There was a problem hiding this comment.
agreed and changed in all instances.
IS_PLIST_MUTABLE asserted that its argument is a plain list, which IS_MUTABLE_OBJ does not. Keep that check in AddPlist3, RemPlist and KTNumPlist; the latter also covers the list entries it inspects, as only KTNumPlist and TypePlistWithKTNum set OBJ_FLAG_TESTING. Assisted-by: Claude Code (Opus 5.5)
lgoettgens
removed their request for review
October 12, 2026 14:07
Member
Author
|
@james-d-mitchell @ChrisJefferson any further concerns or requests? |
ChrisJefferson
approved these changes
Oct 14, 2026
james-d-mitchell
approved these changes
Oct 14, 2026
james-d-mitchell
left a comment
james-d-mitchell
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks @fingolfin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for #6025, which moves the mutability of lists and records from the tnum into an object flag. These commits stop a few places from handling the
IMMUTABLEbit by hand. No change in behaviour.ShallowCopyPlistandElmsPlistDenseuseMUTABLE_TNUMinstead of subtractingIMMUTABLEor comparing against... + IMMUTABLE.KTNumPlistandKTNumHomPlistreturn the mutable tnum.TypePlistHomHelper, which needs the bit to pick the type, adds it back fromIS_MUTABLE_OBJ. This continues kernel: avoid some uses of IMMUTABLE in plist.c #6024 and is the one commit that needs a careful look.IS_PLIST_MUTABLEis replaced byIS_MUTABLE_OBJand removed. I found no use of it in the distributed packages.NEW_PLIST_IMMandNEW_PLIST_WITH_MUTABILITYgo throughMakeImmutableNoRecurseinstead of or-ing the bit into the tnum.AI disclosure: Claude Code (Opus 5.5)