Skip to content

fix: run gren container as non-root by default - #2

Merged
bcurcin-godaddy merged 1 commit into
mainfrom
fix/gren-dockerfile-non-root-user
Sep 28, 2026
Merged

bcurcin-godaddy merged 1 commit into
mainfrom
fix/gren-dockerfile-non-root-user

Conversation

@bcurcin-godaddy

Copy link
Copy Markdown
Collaborator

Summary

  • Adds USER node to the gren release-tooling Dockerfile so the existing unprivileged account is the image’s default runtime user.
  • Package installation remains before this instruction and continues to run as root.
  • Makefile -u $(CURRENT_UID):$(CURRENT_GID) override unchanged; no entrypoint or release-workflow changes.

Context

Retargeted from elastic/ecs-logging-php#103, which incorrectly targeted elastic:main (and pulled in unrelated fork commits / CLA blockers). This PR targets gdcorp-wordpress/ecs-logging-php:main with only the Dockerfile fix.

Validation

  • Semgrep reproduces the missing-user finding on the original Dockerfile and reports none on the modified file.
  • Focused container checks verified UID/GID 1000:1000, access to the CI files, and gren --version as the non-root user.
  • Host UID/GID override and generated-file ownership verified.
  • Whitespace checks passed.

Made with Cursor

@bcurcin-godaddy
bcurcin-godaddy merged commit d831980 into main Sep 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant