Validate since format and publicUrl trailing slash in filteredPodcastFeeds - #726
Merged
Merged
Conversation
…Feeds Fail fast at Nix eval time instead of surfacing as a per-feed "ERROR:" line in the generator's journal output at runtime. - since must match YYYY-MM-DD, checked via builtins.match. - publicUrl must not end in a trailing slash, since the generator appends /<slug>.xml. Suggested by a ChatGPT review of the already-merged #725. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Co-Authored-By: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #725, based on a ChatGPT review of that (already-merged) PR. Adds two eval-time assertions to
genebean.services.filteredPodcastFeedsso bad config fails fast instead of surfacing as a per-feed "ERROR:" line in the generator's journal output at runtime:feeds.<name>.sincemust matchYYYY-MM-DD.publicUrlmust not end in a trailing slash (the generator appends/<slug>.xml).Test plan
pre-commit run --all-filescleandeploy-rs --dry-activate --skip-checksagainstnixnucevaluates cleanly with the current config (no trailing slash, nosinceset) — same derivation as the currently active system, so no rebuild/redeploy needed for this eval-only change🤖 Generated with Claude Code