Skip to content

chore(release): v0.123 RC fixes (#1765, #1715, #1773, #1789) - #1797

Merged
danieljrc888 merged 17 commits into
v0.123-devfrom
chore/v0.123-rc-fixes
Oct 21, 2026
Merged

danieljrc888 merged 17 commits into
v0.123-devfrom
chore/v0.123-rc-fixes

Conversation

@danieljrc888

Copy link
Copy Markdown
Contributor

Delivery context

Release-candidate train for v0.123-dev: lands four reviewed fork PRs together so the combined change gets a single full E2E run. These fork PRs could not be picked up by the E2E dispatcher, and landing them one by one would invalidate each other's E2E snapshot.

Included, each merged with --no-ff at its reviewed head:

PR Head Change
#1765 e414e692 Redact validator private keys from call receipts (sim_call, gen_call, eth_call error data) and explorer payloads, including leader_timeout_validators
#1715 c0019c25 Bind Postgres, Redis and Ollama host ports to 127.0.0.1 (Refs #1603)
#1773 a91e6bbf Normalize addresses to EIP-55 checksum in raw-SQL balance operations
#1789 5d724aa0 Normalize the address in sim_fundAccount

Excluded: #1784 (needs E2E with consensus #1749/#1777) and #1796 (upgrade-reversion finding pending).

No cross-repository Depends-On.

Problem and outcome

Each PR was reviewed individually; see its own description. Once this lands, the four source PRs are closed with a link here.

Implementation and validation

  • Merges are conflict-free on top of v0.123-dev@e59ddfba.
  • tests/unit/ on the combined tree: 1698 passed, 7 skipped.
  • Each source PR's native CI is green at the head listed above.

Co-authored-by: Kanan 93033289+kriss39@users.noreply.github.com
Co-authored-by: Starling 82058629+Starling-spell@users.noreply.github.com
Co-authored-by: Alicepoltora Alicepoltora@users.noreply.github.com

Starling-spell and others added 17 commits July 26, 2026 13:48
debit_account_balance(), credit_account_balance() and
credit_tx_value_once() execute raw SQL keyed by the address, but unlike
get_account()/create_new_account_with_address() they never passed the
address through to_checksum_address(). Accounts are stored keyed by the
checksummed id, so a caller passing a lowercase address (e.g. from a JSON-RPC
'from' field) would:

- debit_account_balance(): match no row and silently return False even when
  the account has sufficient balance;
- credit_account_balance(): hit ON CONFLICT DO NOTHING on the checksummed
  row's id and instead INSERT a new duplicate row keyed by the lowercase
  address, splitting the balance across two accounts;
- refund_tx_value(): credit the refund onto the lowercase duplicate row,
  losing the funds from the sender's perspective.

_normalize_address() centralizes the to_checksum_address() normalization
with the same fallback-on-error semantics get_account() already used, and
is applied to every raw-SQL balance path. Unit tests (no DB required)
verify the SQL parameters are normalized and that non-address values are
passed through unchanged.
sim_fundAccount returned a success-looking result hash but silently
credited nothing when passed a lowercase address (e.g. from MetaMask).
Ethereum JSON-RPC addresses are case-insensitive, so normalize to
checksum format before the lookup.

Closes #1788
# Conflicts:
#	backend/protocol_rpc/endpoints.py
…lization test

The expected address was not a valid EIP-55 checksum, so the test never
passed. fund_account now commits the session (#1760), which object() cannot do.
# Conflicts:
#	backend/database_handler/accounts_manager.py
Redis runs without auth and the official image disables protected-mode, so
publishing it on all interfaces has the same exposure as postgres. Services
reach both over the compose network, not the host port.
The committee entries come from Validator.to_dict(), which includes
private_key, and _serialize_tx returned them unsanitized.
@danieljrc888 danieljrc888 self-assigned this Oct 21, 2026
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2e855a4e-313d-490e-8814-181e5f72049f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@danieljrc888

Copy link
Copy Markdown
Contributor Author

/run-e2e all

Frozen landing cut: #1797 alone (combines #1765, #1715, #1773, #1789 at their reviewed heads), head b9bc31fcb8225e3f7d7ace3a9232e90cd2f3cd9f over v0.123-dev@e59ddfbaa15f19a2d856f184e3e27a30c3007cb2; no cross-repository Depends-On. Full component and stack coverage (no stack selector). Native CI is pending. Merge is authorized once this E2E and native CI are green.

@ci-core-e2e-runner

Copy link
Copy Markdown
Contributor

E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T20:46:48.468679Z b9bc31f PR opened
🔒 Security Review ✅ Completed 2026-10-21T20:47:43.239862Z b9bc31f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@danieljrc888

Copy link
Copy Markdown
Contributor Author

/merge-train

@ci-core-e2e-runner

Copy link
Copy Markdown
Contributor

The request is recorded and waiting for processing. Follow the E2E and merge checks for progress. Do not post a duplicate command.

@ci-core-e2e-runner

Copy link
Copy Markdown
Contributor

The merge request cannot proceed. Check reviews, required CI and the selected landing cut. Related changes may require action by their owners; internal details are available to the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants