Repository navigation
chore(release): v0.123 RC fixes (#1765, #1715, #1773, #1789) - #1797
Conversation
debit_account_balance(), credit_account_balance() and credit_tx_value_once() execute raw SQL keyed by the address, but unlike get_account()/create_new_account_with_address() they never passed the address through to_checksum_address(). Accounts are stored keyed by the checksummed id, so a caller passing a lowercase address (e.g. from a JSON-RPC 'from' field) would: - debit_account_balance(): match no row and silently return False even when the account has sufficient balance; - credit_account_balance(): hit ON CONFLICT DO NOTHING on the checksummed row's id and instead INSERT a new duplicate row keyed by the lowercase address, splitting the balance across two accounts; - refund_tx_value(): credit the refund onto the lowercase duplicate row, losing the funds from the sender's perspective. _normalize_address() centralizes the to_checksum_address() normalization with the same fallback-on-error semantics get_account() already used, and is applied to every raw-SQL balance path. Unit tests (no DB required) verify the SQL parameters are normalized and that non-address values are passed through unchanged.
sim_fundAccount returned a success-looking result hash but silently credited nothing when passed a lowercase address (e.g. from MetaMask). Ethereum JSON-RPC addresses are case-insensitive, so normalize to checksum format before the lookup. Closes #1788
# Conflicts: # backend/protocol_rpc/endpoints.py
…lization test The expected address was not a valid EIP-55 checksum, so the test never passed. fund_account now commits the session (#1760), which object() cannot do.
# Conflicts: # backend/database_handler/accounts_manager.py
Redis runs without auth and the official image disables protected-mode, so publishing it on all interfaces has the same exposure as postgres. Services reach both over the compose network, not the host port.
The committee entries come from Validator.to_dict(), which includes private_key, and _serialize_tx returned them unsanitized.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/run-e2e all Frozen landing cut: #1797 alone (combines #1765, #1715, #1773, #1789 at their reviewed heads), head |
|
E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
/merge-train |
|
The request is recorded and waiting for processing. Follow the E2E and merge checks for progress. Do not post a duplicate command. |
|
The merge request cannot proceed. Check reviews, required CI and the selected landing cut. Related changes may require action by their owners; internal details are available to the team. |
Delivery context
Release-candidate train for
v0.123-dev: lands four reviewed fork PRs together so the combined change gets a single full E2E run. These fork PRs could not be picked up by the E2E dispatcher, and landing them one by one would invalidate each other's E2E snapshot.Included, each merged with
--no-ffat its reviewed head:e414e692sim_call,gen_call,eth_callerror data) and explorer payloads, includingleader_timeout_validatorsc0019c25127.0.0.1(Refs #1603)a91e6bbf5d724aa0sim_fundAccountExcluded: #1784 (needs E2E with consensus #1749/#1777) and #1796 (upgrade-reversion finding pending).
No cross-repository Depends-On.
Problem and outcome
Each PR was reviewed individually; see its own description. Once this lands, the four source PRs are closed with a link here.
Implementation and validation
v0.123-dev@e59ddfba.tests/unit/on the combined tree: 1698 passed, 7 skipped.Co-authored-by: Kanan 93033289+kriss39@users.noreply.github.com
Co-authored-by: Starling 82058629+Starling-spell@users.noreply.github.com
Co-authored-by: Alicepoltora Alicepoltora@users.noreply.github.com