Repository navigation
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
brsbl
marked this pull request as draft
October 4, 2026 10:06
Collaborator
Author
|
Closing: the user decided against new plugin APIs and core changes for this. Digests (brsbl/bb-plugins#240) fixes the scroll jump inside the plugin instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Plugins could expand a section inside a reply, but DOM
scrollIntoViewfought the timeline's bottom anchoring. Digests' routine-email counts opened content above the visible area, with no SDK hook to release the anchor.What changed
experimental_useThreadScroll().scrollIntoView(element, { block, behavior }), restricted to the calling slot instance and containing timeline; requires Plugin SDK 0.6.18 or later.::scroll-demousage.How you verified
instantcalls despite requesting smooth).4d15c1da0a..60288c11e2covered SDK ownership and anchoring and identified composer overlap; fixed it and added end/nearest coverage. Tests also cover ownership, unmount, resize, animated expansion, and new-event resumption.Before:
4d15c1da0a· After:a2798ae240· 2× pixel density. Same synthetic thread, directive markup, route, and expanded state in the isolated branch web app. The baseline fixture uses DOM scrolling; the candidate uses the new SDK hook.BB-Thread-ID: thr_bfxsh3mzue