Keep replay tests off the Docker boundary - #290
Open
webdevtodayjason wants to merge 1 commit into
Open
webdevtodayjason wants to merge 1 commit into
webdevtodayjason wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Startup replay tests could reach the real
get_backendfactory when a test exercised the append core without replacingappend_solo_instance. On a host with Docker, that path could createainode-vllm-node-soloand collide with a real engine.Decision
Patch
ainode.engine.backends.get_backendin the replay module's autouse fixture so every replay test stays behind a fake backend boundary. Keep the backend command-construction tests meaningful by continuing to instantiate those backends directly and patch their subprocess seam. Add a regression test that calls the real append core and proves the resulting engine is the fixture fake with the requested model config.Proof
.venv/bin/pytest -q tests/test_replay_bind_window.py tests/test_browser_federation.py: 50 passed in 7.39s.venv/bin/ruff check: All checks passedainode-vllm*containersChangelog
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.