Count proxied inference tokens in node metrics - #293
Open
webdevtodayjason wants to merge 1 commit into
Open
webdevtodayjason wants to merge 1 commit into
webdevtodayjason wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AINode recorded every proxied request with zero tokens because the proxy discarded upstream usage blocks. Streaming replies, Anthropic Messages replies, and embedding requests therefore left token counters and Prometheus token metrics at zero, and the Metrics view could not truthfully show token throughput.
Decision
Read completion or output token totals from non-streamed JSON replies, parse usage from SSE events without changing forwarded bytes, and count output delta events when a stream has no usage event. Record embedding prompt tokens for both fleet and local embedding paths. Restore the token throughput chart as an interval rate derived from the cumulative counter, while retaining the uptime chart.
The harness counter audit found no code change was needed: it differences counters immediately around each task and already states that concurrent node traffic is included.
Proof
Changelog
Fixed node token metrics and the Metrics token throughput chart for proxied completion, Messages, Responses, streaming, and embedding requests.
Closes #250
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.