Repository navigation
Conversation
appmap-ruby's rspec and minitest hooks enable recording by themselves (DetectEnabled#enabled_by_testing? runs before the APPMAP check). APPMAP=true enables every recording method, requests included, and the gem warns about it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Author
|
Folded into #12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rspec, minitest and rails-test entries in
frameworks.mjssetAPPMAP=trueon the record command. appmap-ruby does not need it, and it does harm:APPMAP=trueenables every recording method, requests included, so a test run also records HTTP requests. The gem prints a warning about exactly this.In appmap-ruby's
DetectEnabled#detect_enabled,enabled_by_testing?runs beforeglobally_enabled?and returns true for rspec, minitest and cucumber with no env var set. So the test hooks turn recording on by themselves.Changes:
frameworks.mjs: the three Ruby frameworks set no environmentframeworks.test.mjs: the test now checks that all three set nothing, and says whySKILL.md: therecord_envrow says it is not needed for Ruby, and whymanifest.template.yaml: the cucumber example dropsAPPMAP=truerecord_envstill works for a project that needs something else.🤖 Generated with Claude Code