Repository navigation
fix: improve operational error reporting across providers - #123
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
getdownandcode
force-pushed
the
fix/error-reporting-issues
branch
from
November 2, 2026 18:33
be8c89f to
85a17bd
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be8c89f062
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacks three related error-reporting fixes into one reviewable change:
POSTGRES_PORTas a stable problem line instead of raising from the deployment credential guard.run_idandstep_no; source OpenAI credentials only from settings; honor OpenAIretry-after-msandretry-afterresponse headers before applying the configured fallback.codetostatus_code.Closes #92 and #111. Addresses item 5 in #113; the remaining independent odds-and-ends are not included.
Codex review follow-up
OpenAI rate-limit errors now read retry delay from
exc.response.headers:retry-after-msis preferred and converted from milliseconds,retry-aftersupports numeric seconds and HTTP-date syntax, and the configuredRETRY_AFTER_FALLBACK_Sis used only when the response headers are missing or invalid.Verification
.venv/bin/pytest -q— passed (real-infrastructure tests skipped because that tier is disabled).venv/bin/ruff check .— passed.venv/bin/ruff format --check .— passed.venv/bin/mypy agentkit— passed