Repository navigation
feat(db): make seed_demo_db.sql idempotent and execute seed.py in docker-compose migrations - #46
Merged
Merged
Conversation
getdownandcode
commented
Oct 1, 2026
getdownandcode
left a comment
getdownandcode
left a comment
Owner
Author
There was a problem hiding this comment.
LGTM: Strict review complete.
seed_demo_db.sqlis now fully idempotent usingON CONFLICT (id) DO NOTHING;.scripts/seed.pyprovides clean async execution with proper transaction context and resource disposal.Dockerfilecopiesscriptsto the runtime image.docker-compose.ymlautomatically runspython scripts/seed.pyafter migrations.- Tested and verified with
tests/integration/test_seed.pyanddocker compose config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ON CONFLICT (id) DO NOTHING;toproductsandordersinsert statements inscripts/seed_demo_db.sqlfor strict idempotency across multiple runs.scripts/seed.pystandalone database seeding script with CLI arguments and programmaticseed_databasehelper.examples/demo.pyto delegate demo database seeding toscripts.seed.seed_database.Dockerfileto copyscripts/into the runtime container image.docker-compose.ymlmigrations service command to["sh", "-c", "alembic upgrade head && python scripts/seed.py"].tests/integration/test_seed.pyverifying repeated runs succeed cleanly without duplicate rows or integrity errors.Verification
ruff check .passedruff format --check .passedmypy agentkit tests examples scriptspassedpytest --cov=agentkit --cov-fail-under=85passed (91.58% coverage)docker compose configpassed