[getdownandcode]

Summary

Eliminate silent fallbacks to FakeLLMClient, InMemoryMemoryStore, and InMemoryTraceSink in production API dependencies (resolving AUD-01, AUD-02, and AUD-03).

What Changed

• In agentkit/api/deps.py:
  • get_memory_store now explicitly requires session_factory and redis_client, raising ServiceUnavailableError (HTTP 503) if absent rather than silently falling back to InMemoryMemoryStore.
  • get_trace_sink now requires session_factory, raising ServiceUnavailableError (HTTP 503) if absent rather than silently falling back to InMemoryTraceSink.
  • get_llm_client now creates the configured provider directly; if initialization fails for a live provider, it raises an exception rather than silently falling back to FakeLLMClient.
  • Unused in-memory and fake imports removed from deps.py.
• In tests/integration/test_api_deps_strict.py:
  • Added test suite asserting strict 503 raising on missing infrastructure and verifying that live LLM providers do not silently degrade to fake clients.

How Tested

• pytest tests/integration/test_api_deps_strict.py
• Full test suite: 242 passed, 24 skipped (real infra flag).
• Linting and typing: ruff and mypy 100% clean.

[getdownandcode]

Peer Review: Strict Infrastructure Resolution in API Dependencies

• Correctness: Verified. get_memory_store and get_trace_sink strictly require configured database and Redis clients, raising ServiceUnavailableError (HTTP 503) instead of falling back to in-memory stand-ins.
• LLM Provider Error Surfacing: Verified. get_llm_client now creates the configured provider directly and allows initialization and authentication errors to propagate rather than falling back to FakeLLMClient.
• Code Cleanliness: Unused in-memory and fake imports removed from deps.py.
• Testing & Safety: All unit and integration tests pass cleanly with 92% coverage.

LGTM.