Repository navigation
fix(llm): wire RetryingLLMClient with MAX_RETRIES in LLM factory - #49
Merged
Merged
Conversation
getdownandcode
commented
Oct 1, 2026
getdownandcode
left a comment
getdownandcode
left a comment
Owner
Author
There was a problem hiding this comment.
Peer Review: Wire RetryingLLMClient into LLM Factory
- Correctness: Verified.
create_llm_client_from_settingswraps live LLM clients withRetryingLLMClient. - Configurability: Verified. Added
MAX_RETRIES(default 3) toSettings. Zero retries returns unwrapped client. - Coverage & Quality: All tests green, type checks pass.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire
RetryingLLMClient(exponential backoff and jitter for transient errors) intocreate_llm_client_from_settings(resolving AUD-04).What Changed
agentkit/config.py: AddedMAX_RETRIES: int = Field(default=3, ge=0)toSettings.agentkit/llm/factory.py: Wrapped live providers (geminiandopenai) withRetryingLLMClient(client, max_retries=settings.MAX_RETRIES)whenMAX_RETRIES > 0.tests/unit/test_llm_factory.py: Added unit tests verifying wrapping, attribute delegation, and unwrapped behavior whenMAX_RETRIES=0or provider isfake.How Tested
pytest tests/unit/test_llm_factory.py