Repository navigation
fix(demo): require explicit API keys in demo and clean up README config - #50
Merged
Merged
Conversation
getdownandcode
commented
Oct 1, 2026
getdownandcode
left a comment
getdownandcode
left a comment
Owner
Author
There was a problem hiding this comment.
Peer Review: Strict Demo Mode & README Configuration Cleanup
- Correctness: Verified.
build_llmraises an explicitValueErrorwhen API keys are absent in live mode instead of silently falling back toFakeLLMClient. - Documentation: Unused
JWT_SECRETandENVIRONMENTremoved from README snippet. - Testing: Passes cleanly with complete assertions.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforce explicit credentials in
examples/demo.pyand clean up unused configuration keys inREADME.md(resolving AUD-05 and AUD-06).What Changed
examples/demo.py:build_llmnow raisesValueErrorwhen running in live mode without the required API key rather than silently degrading toFakeLLMClient.create_llm_client.README.md:ENVIRONMENT=developmentandJWT_SECRET=...from.envsnippet. AddedLLM_MODEL=gemini-2.0-flash.tests/integration/test_demo.py:test_build_llm_strict_live_modeverifying live vs offline execution behavior.How Tested
pytest tests/integration/test_demo.py