chore(e2e): give each harness batch distinct call values - #297
Closed
yosriady wants to merge 1 commit into
Closed
Conversation
The SDK's queue drops an event whose payload is identical to one accepted within the last minute. getformo/sdk#372 makes that window independent of flush timing, and transaction:started has no batch id yet, so three identical batches in one second lost their later started rows to the guard rather than to anything under test. Distinct values per batch keep every row meaningful on the published 1.38.0 and on the fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YEjK9qkwf3u1CpGkb5NvYG
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Contributor
Author
|
Closing with getformo/sdk#375, which it accompanied. Harmless on its own (green against the published SDK) but no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to getformo/sdk's fix for #372 (dedup hash retained for its full 60s window, independent of flush timing).
The batch harness sent the same two calls (same
to,value,data, same wallet, same chain) for theatomic,partialRevertandrejectedsteps within one second.transaction:startedcarries no batch id yet, so those later started rows are byte-identical to the first batch's and the SDK's double-fire guard drops them. That made thepartialRevertandrejectedscenarios fail against the fix for a reason unrelated to what they test.Each batch now uses distinct values. Scenarios match on
[index/size+id], so no expectation changes. Verified green against both the published 1.38.0 and the fix build:sweep.mjs13/13,behaviours.mjs35/35,browser/run.mjsall checks passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01YEjK9qkwf3u1CpGkb5NvYG
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.