Repository navigation
Guard the feed blocks' fetch: public addresses only, no redirects, a size limit - #13
Merged
Merged
Conversation
…size limit Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rssanddynamic_feedblocks fetchedfeed_urlfrom the server with no check on where it pointed. They now go throughOutboundUrlGuard:mail-builder.feeds.max_bytes(default 1 MB) is ignored;mail-builder.feeds.allowed_hostslets a host through, for feeds served from your own network.Tests: a table of refused URLs (nothing is sent), a public feed still works, redirects are not followed, size limit, allowed host, and the address classification. The test case binds a guard that never touches DNS. I also ran the real resolver against real names and the odd IP forms by hand.
README gets a short "Feed blocks" section. Needs a patch release (2.5.1) so that applications using the editor or the compiler get it.
🤖 Generated with Claude Code