Repository navigation
MailEditor::theme(): type the closure loosely - #6
Merged
Merged
Conversation
A Filament closure may take injected parameters such as $get, so the docblock no longer claims it takes none. Static analysis in a project that passes fn (Get $get) rejected the narrower type. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PHPDoc-only fix.
MailEditor::theme()was documented as takingClosure(): (array|null), i.e. a closure with no parameters, but a Filament closure may take injected parameters ($get,$record, ...), and the documented use isfn (Get $get): array => .... PHPStan incrm-prorejected exactly that call. The parameter is nowarray|Closure, with the docblock saying what a closure may take. No behaviour change; 111 tests, PHPStan and Pint pass. For a v2.2.1 patch release.🤖 Generated with Claude Code