Repository navigation
feat(changelog): Preview PRs in every release workspace they land in - #942
Merged
Merged
Conversation
Co-Authored-By: Burak Yigit Kaya <126780+BYK@users.noreply.github.com>
Contributor
|
BYK
approved these changes
Oct 28, 2026
8 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #941.
The changelog preview workflow didn't work in repos that define release workspaces.
craft changelog --pr Nfailed because no workspace was selected, and the workflow hid the error, so every PR showed "No changelog entries" with no bump. Even with a workspace selected, the current PR was always added to the preview without the workspace path rules, so a server-only PR showed up as a bump in a client's changelog.What changes
craft changelog --pr Npreviews the PR in each workspace, starting from that workspace's latest tag. It keeps only the workspaces whose changelog would list the PR. The JSON output gets aworkspacesarray (name,bumpType,versioningPolicy).changelogholds the PR's own entry once, since the entry text is the same in every workspace.includePaths,unownedPaths. A PR outside the workspace is left out and doesn't bump the version. To support this, the path matching ingetChangesSincemoved intogetWorkspaceChangeFilter()so both callers share it.CalVer), and the status description reads e.g.clients/python: Minor, clients/rust: Patch. When a PR lands in no workspace, the preview says so, and title enforcement is skipped as it is forskip-changelog. Repos without workspaces get the same output as before.I ran the built binary against the three-workspace config in getsentry/objectstore#737:
objectstore-service. It now lands only inobjectstore-server(CalVer).clients/python, as a major bump.unownedPaths: exclude, so it lands in none.Callers that pin
craft-versionneed a release with this change. The defaultlatestpicks it up.via @BYK.
--
View Junior Session [Sentry]