Skip to content

Stop using the literal name "Junior" as the Briefs attribution token #2415

Open

Description

@sentry-junior

Follow-up to #2374, which removed the literal name "Junior" from text the model reads. The bot name can be configured. #2374 left Briefs alone on purpose.

In packages/junior/src/chat/briefs/generate.ts, "Junior" is a stored attribution value. participantNames maps junior to "Junior", and the checks at about line 182 use by === "Junior" to stop the bot from stating or confirming a decision for a person. Stored Briefs go back to the model, so the literal name also reaches model-visible text. briefs/prompt.ts and render.ts use it too.

To decide:

  • Which token replaces it: the configured bot name, or a fixed role token such as assistant.
  • What to do with existing stored Briefs: migrate them, or accept both tokens when reading.

Done when: Briefs show the configured bot name, the attribution checks still stop the bot from confirming a person's decision, and old Briefs still load.

via David Cramer.

--

View Session [Sentry]

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions