Skip to content

fix(dev): Share one @sentry/junior copy between the app and dashboard #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasjiangcy merged 1 commit into from
Oct 29, 2026
Merged

fix(dev): Share one @sentry/junior copy between the app and dashboard #2363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/dev-server.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,11 @@ function syncInjectedPackageDist(packageName, packageDir, options = {}) {
// `node_modules/.pnpm/...`, not directly from `packages/*`.
// Point the injected package `dist` at the live workspace build output so
// `pnpm dev` executes the latest local build without recursive copy races.
const injectedPackageDirs = [workspaceRoot, exampleDir]
// Node resolves the linked dashboard `dist` to `packages/junior-dashboard`,
// so the dashboard imports `@sentry/junior` from its own injected copy.
// Link that copy too. Otherwise the app and the dashboard load two module
// instances, and in-memory state that one writes is not visible to the other.
const injectedPackageDirs = [workspaceRoot, exampleDir, dashboardPackageDir]
.map((consumerDir) => resolveInjectedPackageDir(packageName, consumerDir))
.filter((value, index, values) => value && values.indexOf(value) === index);
if (injectedPackageDirs.length === 0) {
Expand Down
Loading