Skip to content

fix(google): Let the requester be optional in findMeetingTimes - #2375

Merged
dcramer merged 1 commit into
mainfrom
fix/google-requester-optional
Oct 29, 2026
Merged

dcramer merged 1 commit into
mainfrom
fix/google-requester-optional

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

findMeetingTimes always added the requester as a required attendee through withRequester(). Then it dropped every optionalAttendees entry that was already required. So when the model passed attendees: [sam] and optionalAttendees: [requester], the requester stayed required, and the optional entry was silently lost. The requester's holds still blocked every slot.

This made the scheduling eval case "when the requester corrects a one-sided answer, check the other attendee without asking again" fail in the live runs on #2371. The model correctly made the requester optional because their afternoons are only holds. It got slots: [], with both people in checked, and then gave up.

Now an explicit optionalAttendees entry for the requester wins over the automatic add. When the requester is in neither list, the tool still adds them as required. When they are in both lists, they stay required. The attendees and optionalAttendees descriptions now tell the model that it can mark the requester optional.

createCalendarEvent also uses withRequester(), but this PR does not change it. Its test intentionally keeps the requester required on the invite even when they are also listed as optional. Open question: should the invite follow the same rule?

via David Cramer.

--

View Junior Session [Sentry]

Co-Authored-By: David Cramer <david@sentry.io>
@vercel

vercel Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
junior-docs Ready Ready Preview Oct 29, 2026 5:52pm UTC

Request Review

@sentry-evals

sentry-evals Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Sentry Evals

junior-behavioral

Run Status Passed Failed Errored Cost Tokens Duration
Head Error 80 1 2 $0.58 0 570.17s

Base commit 0f21f18 has no eval run to compare against.

junior-guardian

Run Status Passed Failed Errored Cost Tokens Duration
Head Passed 94 0 0 $0.03 0 26.52s

Base commit 0f21f18 has no eval run to compare against.

@dcramer
dcramer marked this pull request as ready for review October 29, 2026 18:08
@dcramer
dcramer merged commit 8ca0abd into main Oct 29, 2026
49 of 60 checks passed
@dcramer
dcramer deleted the fix/google-requester-optional branch October 29, 2026 18:09
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Oct 29, 2026

This branch was successfully deployed

1 active deployment
Preview – junior-docs — 4e564ad7 Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant