Repository navigation
fix(google): Let the requester be optional in findMeetingTimes - #2375
Merged
Merged
Conversation
Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sentry Evalsjunior-behavioral
Base commit junior-guardian
Base commit |
dcramer
approved these changes
Oct 29, 2026
dcramer
marked this pull request as ready for review
October 29, 2026 18:08
This was referenced Oct 30, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findMeetingTimesalways added the requester as a required attendee throughwithRequester(). Then it dropped everyoptionalAttendeesentry that was already required. So when the model passedattendees: [sam]andoptionalAttendees: [requester], the requester stayed required, and the optional entry was silently lost. The requester's holds still blocked every slot.This made the scheduling eval case "when the requester corrects a one-sided answer, check the other attendee without asking again" fail in the live runs on #2371. The model correctly made the requester optional because their afternoons are only holds. It got
slots: [], with both people inchecked, and then gave up.Now an explicit
optionalAttendeesentry for the requester wins over the automatic add. When the requester is in neither list, the tool still adds them as required. When they are in both lists, they stay required. TheattendeesandoptionalAttendeesdescriptions now tell the model that it can mark the requester optional.createCalendarEventalso useswithRequester(), but this PR does not change it. Its test intentionally keeps the requester required on the invite even when they are also listed as optional. Open question: should the invite follow the same rule?via David Cramer.
--
View Junior Session [Sentry]