Repository navigation
fix(dashboard): Keep Escape, location, and review chips working in the context panel - #2604
Merged
Merged
Conversation
…e context panel Escape on the open menu no longer closes details too. Mobile details show the location again. A review chip expands its question when details are already open. Co-Authored-By: Thomas Jiang <thomas.jiang@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
6 screenshot changes — 6 changed · 0 added · 0 removed Review screenshots in Frameshift
|
thomasjiangcy
approved these changes
Nov 3, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the three Bugbot findings on #2603, which merged before this fix landed on that branch.
⋯menu and Details together. Both listened for Escape ondocument, and the Details listener was registered first. The menu now listens in the capture phase and callspreventDefault, which Details already checks, so Escape closes only the menu.md. Details now shows a Location row again, on mobile only.ReviewItemRowread its expanded state only on mount. It now expands when the highlight turns on.The existing e2e tests for each flow now cover these cases.
--
View Session [Sentry]