Repository navigation
fix(dashboard): Anchor the Inbox count badge to the icon - #2609
Merged
Merged
Conversation
The nav rail badge sat on the top-right corner of the 40px button, so it floated away from the Inbox icon. Center it near the top-right corner of the 20px icon instead. Co-Authored-By: Thomas Jiang <20501235+thomasjiangcy@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thomasjiangcy
approved these changes
Nov 3, 2026
Contributor
|
13 screenshot changes — 13 changed · 0 added · 0 removed Review screenshots in Frameshift
Show 7 more changed screenshots
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2586. The nav rail count badge sat on the top-right corner of the 40px button, so it read as part of the button, not the Inbox icon.
The badge is now at
top-0 right-0of the 40px item. Its center is 2px outside the top-right corner of the 20px icon, so it overlaps the icon corner and most of the glyph stays visible.99+still grows to the left over the icon.Checked in a local Playwright run of the dashboard harness with a mocked review count, in the default and active (
/review) states.via @thomasjiangcy.
--
View Session [Sentry]