Skip to content

ref(dashboard): Show only a lock icon for private conversations in the title bar - #2644

Merged
thomasjiangcy merged 1 commit into
mainfrom
ref/dashboard-hide-public-marker
Nov 4, 2026
Merged

thomasjiangcy merged 1 commit into
mainfrom
ref/dashboard-hide-public-marker

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

The conversation title bar is short on space. The labeled Public/Private pill took a fair amount of it.

Public is the default, so the title bar now shows no marker for public conversations. Private conversations get a lock icon only, with the full explanation in the tooltip and for screen readers. This matches the conversation list, which also marks only private conversations with a lock.

via @thomasjiangcy.

--

View Session [Sentry]

@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
junior-docs Ready Ready Preview Nov 4, 2026 7:41am UTC

Request Review

@sentry-junior

sentry-junior Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

check / types and test / junior unit failed here because of a break on main, not this PR: web-batch-messages.test.ts imported webActorFromEmail, which #2630 removed (TS2305). #2643 fixed it on main as e35103a2d. Rebase onto main to clear those checks. ci / required failed only because those two did.

…e title bar

Co-Authored-By: Thomas Jiang <20501235+thomasjiangcy@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

9 screenshot changes — 9 changed · 0 added · 0 removed

Review screenshots in Frameshift

Conversation Image Reply · Desktop
Conversation Image Reply · Desktop
Changed
Conversation Outbox Author · Desktop
Conversation Outbox Author · Desktop
Changed
Conversation Queue Compact · Desktop
Conversation Queue Compact · Desktop
Changed
Conversation Share Details · Desktop
Conversation Share Details · Desktop
Changed
Conversation Sidebar Review Chip · Desktop
Conversation Sidebar Review Chip · Desktop
Changed
Conversation Sidebar Review Chip Light · Desktop
Conversation Sidebar Review Chip Light · Desktop
Changed
Show 3 more changed screenshots
Conversation Stop Active · Desktop
Conversation Stop Active · Desktop
Changed
Conversation Subagents · Desktop
Conversation Subagents · Desktop
Changed
Settings Mcp · Desktop
Settings Mcp · Desktop
Changed

@thomasjiangcy
thomasjiangcy merged commit 92a465b into main Nov 4, 2026
44 checks passed
@thomasjiangcy
thomasjiangcy deleted the ref/dashboard-hide-public-marker branch November 4, 2026 07:44

This branch was successfully deployed

1 active deployment
Preview – junior-docs — 7bb34014 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant