Repository navigation
fix(android): Ignore non-element manifest children - #701
Merged
Merged
Conversation
Keep manifest conversion focused on element nodes so embedded text does not prevent APK metadata extraction. Cover the failure with a synthetic binary XML fixture compiled by aapt2. Fixes EME-1335
Contributor
Size Analysis1 component analyzed, 1 component processing iOS Builds
Android Builds
|
Contributor
📲 Install BuildsiOS
Android
|
jamieQ
marked this pull request as ready for review
October 16, 2026 21:47
runningcode
approved these changes
Oct 19, 2026
| def _load_manifest_with_text(fixtures_root: Path) -> bytes: | ||
| # Synthetic manifest compiled with aapt2: | ||
| # <manifest><application><activity> | ||
| # <meta-data android:name="com.example.flag" android:value="true" />example text |
Contributor
There was a problem hiding this comment.
this example helps visualize this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APK manifests containing text between elements fail processing because conversion treats
XmlCDatachildren as elements and accesses their missingnamespace_urifield.Convert only element children, since manifest values are stored in attributes. Add a synthetic binary XML fixture compiled with
aapt2to verify that text is skipped while neighboring elements, attributes, and extracted metadata are preserved.Fixes EME-1335