Repository navigation
docs: Explain how to find values that change between runs - #35
Merged
Merged
Conversation
A value that changes on each run and that no pattern finds makes a request go live on every run, with no error. Add the check to do after setup, a way to capture request bodies to compare, and the sources found in Warden. Co-Authored-By: David Cramer <23610+dcramer@users.noreply.github.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A value that changes on each run and that no pattern finds gives a new key on each run. The request goes live and records again every time, and no error shows it. Warden hit this with its random finding ids (getsentry/warden#564): e2e and security-review tests stayed partly live on every CI run while the tests passed.
This adds a "Find changing values" section to the README:
liveon the second run must be about 0.ROACH_MODE=replay, no token).fetchrequest body, so you can diff two runs. Recordings do not keep request bodies.HOME, locale), and array order."Use with vitest" and
TELEMETRY.mdlink to the section.The snippet was checked in Node 24 with a string body, a
Requestinput, and a GET.Docs only. No release needed.
via @dcramer.
--
View Session [Sentry]