Repository navigation
revert: Mark mach and signal crashes as synthetic - #8975
Merged
Merged
Conversation
This reverts commit b45b76b (#8919). Reason: the server-side prerequisite has not landed. Sentry couples metadata.type to the synthetic flag, so until getsentry/sentry#123322 decouples them, an Apple crash without uploaded debug files is titled <unknown> instead of SIGSEGV: Signal 11, Code 1. The flag has to follow that change, not precede it. Reverts the whole commit, including the mechanism.handled fix that rode along in the same PR. Claude-Session: https://claude.ai/code/session_01Myh92Par6JkotmkmYe3adz
bitsandfoxes
requested review from
NinjaLikesCheez,
itaybre,
noahsmartin and
philprime
as code owners
September 8, 2026 06:43
bitsandfoxes
added
the
run-full-ci
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
NinjaLikesCheez
approved these changes
Sep 8, 2026
📲 Install BuildsiOS
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e3070ad | 1240.00 ms | 1274.43 ms | 34.43 ms |
| ffb6adc | 1218.60 ms | 1247.47 ms | 28.87 ms |
| 786f763 | 1217.17 ms | 1238.37 ms | 21.20 ms |
| 521cbf9 | 1224.32 ms | 1250.58 ms | 26.26 ms |
| 0303c4f | 1229.73 ms | 1264.79 ms | 35.06 ms |
| 62680a0 | 1226.71 ms | 1262.00 ms | 35.29 ms |
| 8ec97f1 | 1201.92 ms | 1249.20 ms | 47.28 ms |
| 62b3fa6 | 1228.39 ms | 1262.88 ms | 34.48 ms |
| 53773e2 | 1226.96 ms | 1261.50 ms | 34.54 ms |
| f0c60b7 | 1213.90 ms | 1252.33 ms | 38.44 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e3070ad | 24.14 KiB | 1.16 MiB | 1.14 MiB |
| ffb6adc | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| 786f763 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 521cbf9 | 24.14 KiB | 1.29 MiB | 1.27 MiB |
| 0303c4f | 24.14 KiB | 1.24 MiB | 1.21 MiB |
| 62680a0 | 24.14 KiB | 1.20 MiB | 1.18 MiB |
| 8ec97f1 | 24.14 KiB | 1.31 MiB | 1.28 MiB |
| 62b3fa6 | 24.14 KiB | 1.32 MiB | 1.29 MiB |
| 53773e2 | 24.14 KiB | 1.23 MiB | 1.21 MiB |
| f0c60b7 | 24.14 KiB | 1.22 MiB | 1.20 MiB |
4 of 9 tasks
philprime
pushed a commit
that referenced
this pull request
Sep 11, 2026
Reland of #8919, reverted in #8975 because the server-side fix that keeps the exception type as a title fallback had not landed. The fabricated mach and signal exceptions carry a platform label as their type, not the identity of what went wrong, so it must not split an Apple crash from the same crash on other platforms. Also sets mechanism.handled outside the mach-context branch, which previously left it unset on a report without mach context. Claude-Session: https://claude.ai/code/session_01E57gchi6ER5aruqwjCKe9F
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b45b76b (#8919).
Reason: the server-side prerequisite has not landed. See getsentry/sentry#123322
Sentry couples metadata.type to the synthetic flag, so until this gets decoupled them, an Apple crash without uploaded debug files is titled instead of SIGSEGV: Signal 11, Code 1. The flag has to follow that change, not precede it.
#skip-changelog