test: sentry-cocoa #8921 cancel-crash fix (do not merge) - #5537
Draft
jamescrosswell wants to merge 3 commits into
Draft
test: sentry-cocoa #8921 cancel-crash fix (do not merge)#5537jamescrosswell wants to merge 3 commits into
jamescrosswell wants to merge 3 commits into
Conversation
Points modules/sentry-cocoa at getsentry/sentry-cocoa#8921 so CI produces a Sentry.Maui package containing the proposed fix for the NSURLSessionTask cancel crash, for the reporter of #5519 to verify against his own reproduction. Not for merge - the submodule points at an unmerged branch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5537 +/- ##
==========================================
+ Coverage 74.67% 74.71% +0.04%
==========================================
Files 515 515
Lines 18909 18948 +39
Branches 3691 3696 +5
==========================================
+ Hits 14120 14157 +37
- Misses 3905 3908 +3
+ Partials 884 883 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The #8921 branch sits on newer sentry-cocoa main than 9.26.1, which adds maxFeatureFlags and the scope create/clone/withCurrent APIs. Bindings taken verbatim from the failing macOS job's diff; blob hash matches CI's output. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
CI packs Release builds without a suffix, so this branch was producing packages versioned 6.10.0 - which is already published. A tester could then resolve the real 6.10.0 from nuget.org (or from their global cache) instead of this build, with no way to tell which one they were running. Do not merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge
modules/sentry-cocoapoints at an unmerged branch — getsentry/sentry-cocoa#8921. This branchexists only so CI produces a
Sentry.Mauipackage containing that proposed fix, for the reporter of#5519 to test against his own reproduction.
Context
#5519 is an
EXC_BAD_ACCESSin-[NSURLSessionTask cancel]on iOS when native swizzling is enabledand a retry policy disposes a 5xx response while the body is still streaming. I reduced it to a
minimal reproduction and filed it upstream as getsentry/sentry-cocoa#8917; #8921 is the proposed fix
(skip the private
setCurrentRequest:when the task is already canceling or completed).We could not verify the fix locally: the reproduction stopped firing on my machine, and the unfixed
control also came back 0/10, so the experiment has no discriminating power. The reporter reproduces
reliably on his own hardware, so the practical route is to hand him a build.
Building it here rather than using a prebuilt sentry-cocoa artefact, since our bindings build passes
its own parameters.
#skip-changelog