Skip to content

test: serialize profiling test classes - #5542

Open
elkampu wants to merge 1 commit into
getsentry:mainfrom
elkampu:fix/profiling-tests-serial-collection
Open

test: serialize profiling test classes#5542
elkampu wants to merge 1 commit into
getsentry:mainfrom
elkampu:fix/profiling-tests-serial-collection

Conversation

@elkampu

@elkampu elkampu commented Sep 4, 2026

Copy link
Copy Markdown

Summary

  • replace the unused collection definition on SamplingTransactionProfilerTests with a dedicated profiling test collection
  • make both test classes that create real profiler factories join that non-parallel collection

Fixes #5524.

Testing

  • dotnet test test/Sentry.Profiling.Tests/Sentry.Profiling.Tests.csproj --framework net10.0 -p:NO_ANDROID=true (27 passed, 3 intentionally skipped)
  • dotnet format test/Sentry.Profiling.Tests/Sentry.Profiling.Tests.csproj --no-restore --verify-no-changes --include test/Sentry.Profiling.Tests/SamplingTransactionProfilerTests.cs test/Sentry.Profiling.Tests/ProfilingSentryOptionsExtensionsTests.cs test/Sentry.Profiling.Tests/ProfilingTestCollection.cs -p:NO_ANDROID=true
  • git diff --check

#skip-changelog

Co-Authored-By: OpenAI Codex <codex@openai.com>
@github-actions github-actions Bot added the risk: low PR risk score: low label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low PR risk score: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Profiling tests never actually opt out of parallel execution

1 participant