chore(deps): Refresh mix.lock files#1131
Open
sentry-release-bot[bot] wants to merge 1 commit into
Open
Conversation
| "gproc": {:hex, :gproc, "1.2.0", "b06dc2a5aaa78f8902e6c0032f29362ea1c1cda941216f085a04a76fc0cdf7cc", [:rebar3], [], "hexpm", "70c6f8c91fa5974296cd87974949d8eab953230414f31c4a623ff75131e0827a"}, | ||
| "grpcbox": {:hex, :grpcbox, "0.18.0", "ccc14ec546509e0952d406ef626c5856b68d36a40be6040fa444b375b33bd14f", [:rebar3], [{:acceptor_pool, "~> 1.0.0", [hex: :acceptor_pool, repo: "hexpm", optional: false]}, {:chatterbox, "~> 0.16.0", [hex: :ts_chatterbox, repo: "hexpm", optional: false]}, {:ctx, "~> 0.6.0", [hex: :ctx, repo: "hexpm", optional: false]}, {:gproc, "~> 1.2.0", [hex: :gproc, repo: "hexpm", optional: false]}], "hexpm", "5ec9f8fe664ab51201b32c117a61511a1f9d6316771e3891ba8a88d289a732ab"}, | ||
| "hackney": {:hex, :hackney, "1.20.1", "8d97aec62ddddd757d128bfd1df6c5861093419f8f7a4223823537bad5d064e2", [:rebar3], [{:certifi, "~> 2.12.0", [hex: :certifi, repo: "hexpm", optional: false]}, {:idna, "~> 6.1.0", [hex: :idna, repo: "hexpm", optional: false]}, {:metrics, "~> 1.0.0", [hex: :metrics, repo: "hexpm", optional: false]}, {:mimerl, "~> 1.1", [hex: :mimerl, repo: "hexpm", optional: false]}, {:parse_trans, "3.4.1", [hex: :parse_trans, repo: "hexpm", optional: false]}, {:ssl_verify_fun, "~> 1.1.0", [hex: :ssl_verify_fun, repo: "hexpm", optional: false]}, {:unicode_util_compat, "~> 0.7.0", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm", "fe9094e5f1a2a2c0a7d10918fee36bfec0ec2a979994cff8cfe8058cd9af38e3"}, | ||
| "h2": {:hex, :h2, "0.10.4", "31ef580056e19977b6542eea2718aa19a45841205cd82cd48535dd7683caea4c", [:rebar3], [], "hexpm", "8350920ac7c259fb759a2830d3ce0dd248c48422a031d1760bebdd2020fa30a9"}, |
There was a problem hiding this comment.
Bug: The major version upgrade of hackney to 4.6.0 introduces a breaking change. The call to :hackney_pool.child_spec/2 in Sentry.HackneyClient will likely fail, causing application startup crashes.
Severity: CRITICAL
Suggested Fix
The Sentry.HackneyClient implementation should be updated to be compatible with the new pooling API in hackney 4.x. Before merging, verify the correct way to start a supervised connection pool in the new version and adjust the child_spec function accordingly. Alternatively, pin the hackney dependency to a compatible ~> 1.20 version to prevent this breaking change until the client can be updated.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: mix.lock#L32
Potential issue: The `hackney` dependency is being upgraded from version 1.20.1 to
4.6.0, which is a major rewrite. The default HTTP client, `Sentry.HackneyClient`,
directly calls `:hackney_pool.child_spec/2` to start its connection pool. This
function's API has likely changed or been removed in the new version of `hackney`. As a
result, when `Sentry.Application` attempts to start the client, the call will fail,
causing a runtime crash. This will prevent any application using the default Sentry
configuration with Hackney from starting successfully. The existing code guard only
checks if the `:hackney_pool` module is loaded, not if the function signature is valid.
Also affects:
mix-1.18.lock:32~32mix-1.15-1.17.lock:32~32
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated weekly refresh of the committed
mix.lockfiles (including the per-Elixir-version-range lockfiles) viamix deps.update --all, keeping dependency pins current with the latest security patches allowed by each project's version constraints.#skip-changelog
Action required
🤖 Automatically created by .github/workflows/update_lockfiles.yml.