feat: apply sensitive data filters to grpc & sql#1333
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
6c7bf59 to
9e3a4cd
Compare
f8baa8f to
7e6b84c
Compare
9e3a4cd to
eb15116
Compare
7e6b84c to
5eda06c
Compare
eb15116 to
cdae5e0
Compare
5eda06c to
e875b27
Compare
cdae5e0 to
b0f2552
Compare
e875b27 to
3a856b9
Compare
b0f2552 to
a10bcaa
Compare
a10bcaa to
1c717f4
Compare
3a856b9 to
6a5d2c6
Compare
1c717f4 to
212ed30
Compare
fb04b19 to
d53a01b
Compare
b75a56b to
0ff9c58
Compare
a00b7cb to
0048667
Compare
0ff9c58 to
7f9cb0b
Compare
0048667 to
c3e6aeb
Compare
a407d39 to
98cb8dd
Compare
98cb8dd to
ed9967f
Compare
ed66d64 to
b4614a1
Compare
ed9967f to
753d7fa
Compare
This also removes the unused IsSensitiveHeader. This was a workaround for filtering grpc sensitive headers, but is now included under DataCollection
b4614a1 to
e1a1006
Compare
753d7fa to
8bd0126
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8bd0126. Configure here.
| ctx := make(map[string]any, len(filtered)) | ||
| for key, value := range filtered { | ||
| ctx[key] = value | ||
| } |
There was a problem hiding this comment.
Cookies lost when headers off
Medium Severity
In metadataToContext, cookie and set-cookie metadata are merged into the same map passed to FilterRequestHeaders. When HTTPHeaders.Request uses CollectionOff, that helper returns nil for the whole map, so filtered cookie metadata is dropped even while CollectCookies() remains enabled.
Reviewed by Cursor Bugbot for commit 8bd0126. Configure here.


Description
This adds the sensitive data collection filters to grpc and sql. It also removes the now unused
IsSensitiveHeader.#skip-changelog
Issues
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)