ci: Assign server team as codeowner for server-utils package#21600
ci: Assign server team as codeowner for server-utils package#21600nicohrubec wants to merge 2 commits into
Conversation
Move vendored tedious span creation onto Sentry's span APIs (startInactiveSpan/withActiveSpan), fold the origin into creation, drop the spanStart hook + semconv-stability branching, and expand+un-skip the integration suite to cover all patched methods + the error path. Adds a getSpanName unit test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 24e73e8. Configure here.
| }); | ||
| Object.defineProperty(req, INJECTED_CTX, { value: true }); | ||
| const buf = Buffer.from(traceparent, 'utf8'); | ||
| req.addParameter('opentelemetry_traceparent', (tediousModule as any).TYPES.VarBinary, buf, { |
There was a problem hiding this comment.
Missing db op on spans
Medium Severity
The tedious patch creates DB spans via startInactiveSpan with SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN in attributes but does not pass op: 'db' or set SEMANTIC_ATTRIBUTE_SENTRY_OP. SDK conventions require both origin and op when using startInactiveSpan, matching patterns such as the connect and dataloader instrumentations.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 24e73e8. Configure here.
1 participant
Noticed that #21490 did not assign any reviewers. Adding the server group for this package.